[PATCH:evdev] Remove the reopen timer logic.
peter.hutterer at who-t.net
Tue Oct 20 05:38:11 PDT 2009
On Tue, Oct 20, 2009 at 04:40:09PM +0900, Keith Packard wrote:
> Excerpts from Peter Hutterer's message of Tue Oct 20 15:17:20 +0900 2009:
> > This logic was needed in older kernels that sometimes gave error messages
> > after coming back from resume (2.6.27 release kernels). I haven't seen any
> > log files that needed this reopen timer in a long time, suggesting that need
> > for it is gone.
> I can see removing the config option here, but is the re-open logic
> causing any trouble in the driver?
The reason it exists is solely the issue mentioned above and it has been the
source of a few bugs, some of them quite hard to debug. Most recently 23048
which took quite a while to triage. The reopen logic complicates the driver
and doesn't seem to be necessary anymore. It's just dead weight now.
FWIW, I wanted to get this patch in after 2.3.0 so we have ample time to
revert it before 2.4.0 comes out should that be necessary. It won't land on
the 2.3.x stable updates.
More information about the xorg-devel