[PATCH] Define FD_SETSIZE on Cygwin regardless of XWin DDX

Thomas Dickey dickey at his.com
Wed Oct 21 12:12:40 PDT 2009

On Mon, 19 Oct 2009, Keith Packard wrote:

> Excerpts from Yaakov (Cygwin/X)'s message of Mon Oct 19 12:38:15 +0900 2009:
>> it would be safer to use CFLAGS.
> If you're not #including dix-config.h before any system headers, you're
> doing it wrong. All of the server sources should include that before
> anything else.

For that particular case, true.  However, using AC_DEFINE for example to 
adjust definitions (using gcc as an example) which are tested in 
features.h and/or cdefs.h is a sure way to produce nonportable code.

(I took a quick look at current git to see that this aspect is abused, and 
aside from noting that it's a problem with the code will not bother to 
list every occurrence).


Thomas E. Dickey

More information about the xorg-devel mailing list