C99 types patch

Mark Kettenis mark.kettenis at xs4all.nl
Tue Oct 27 08:39:40 PDT 2009

> Date: Wed, 21 Oct 2009 23:56:46 -0400
> From: Eamon Walsh <ewalsh at tycho.nsa.gov>
> >> I would love love love to see us move entirely to stdint types instead
> >> of the mess we've got now.
> >>     
> > Yes.  Yes yes yes.
> >   
> I have a patch sitting around that does this, guess I'll float it.

Hmm, isn't this going to weak havoc for C++?  If I read your diff
correctly, it'll change from

  typedef unsigned long XID;

into what's effectively

  typedef uint32_t XID;

on 32-bit systems.

Now if your system defines uint32_t as:

  typedef unsigned int uint32_t;

this will change how C++ functions that take an XID as one of its
arguments are magled, causing major ABI breakage.

More information about the xorg-devel mailing list