[PATCH] Supply all code using dl*() with DLOPEN_LIBS

Mikhail Gusarov dottedmag at dottedmag.net
Thu Oct 29 06:16:19 PDT 2009

Twas brillig at 06:06:10 29.10.2009 UTC-07 when dbn.lists at gmail.com did gyre and gimble:

 >> +libglxdri_la_LIBADD = @DLOPEN_LIBS@

 DN> Is there a reason not to just use the variable $(DLOPEN_LIBS)? 

Use where?

Do you just mean s/@DLOPEN_LIBS@/$(DLOPEN_LIBS)/g ?

 DN> This just makes it so -ldl is unnecessarily hardcoded into another
 DN> variable.

Uhm, what's the proper way of declaring "this particular piece of code
uses dlopen and needs linking to corresponding library"? Adding it to
LIBADD for .la containing the code seems to be a most sane decision.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091029/31ed4efe/attachment.pgp 

More information about the xorg-devel mailing list