[PATCH 2/2] Add XORG_DEFAULT_OPTIONS meta-macro.
peter.hutterer at who-t.net
Tue Sep 1 16:09:40 PDT 2009
On Tue, Sep 01, 2009 at 12:59:34AM -0700, Alan Coopersmith wrote:
> Peter Hutterer wrote:
> > Many modules use the same set of m4 macros. Additions to the macros require
> > updating the configure.ac for each module affected. In the case of e.g.
> > protos and libs this means updating every single module.
> As someone who has done many of these updates I like this idea a lot.
> > +AC_DEFUN([XORG_DEFAULT_OPTIONS], [
> > +XORG_CWARNFLAGS
> > +XORG_STRICT_OPTION
> > +XORG_CHECK_MALLOC_ZERO
> Do many modules need the check for malloc(0) != NULL? I see it in some
> of the libraries (and suspect it's in too many of those), but not
> most other modules.
oops, got carried away there. I'll remove and amend.
> > +XORG_RELEASE_VERSION
> I was going to suggest removing this one, but on review, it's still useful for
> setting the PACKAGE_VERSION_* variables, but could have the bits removed for
> --with-release-version handling (those are a holdover from the days
> when we were going to have katamaris regenerate every tarball with the X11R7.x
> version number in the names, something we abandoned after about X11R7.1.)
More information about the xorg-devel