[PATCH 1/2] Add XORG_STRICT_OPTION macro for strict compilation option

Daniel Stone daniel at fooishbar.org
Wed Sep 2 19:27:03 PDT 2009


On Wed, Sep 02, 2009 at 12:36:29PM +0800, Alan Coopersmith wrote:
> The one additional thought I have is should this take an optional
> argument for the default value, so that maintainers can make it be
> on by default in their modules on a case-by-case basis?
> (Perhaps with arguments of "yes", "no" (the default), and "git"
>   (yes if $(top_srcdir)/.git exists, otherwise no).)


People are going to go 'man my module is literally perfect, I'm going to
enable -pedantic -Werror'.  Then someone will build with a newer gcc, or
find some crap headers from an external project we depend on, or the
insane way we have to screw around with our build environment will mean
that under some systems, we're going to get warnings.  And the build
will fail.

It's a very useful development tool, don't get me wrong, but we can't
ever ship a tarball with -Werror enabled.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090903/a9f8ace4/attachment.pgp 

More information about the xorg-devel mailing list