[PATCH] xfree86: vgaarb: make arbiter optional at build time (v2)

[Tiago Vignatti]

On Mon, Sep 14, 2009 at 08:42:08AM +0200, ext Peter Hutterer wrote:
> On Fri, Sep 11, 2009 at 07:04:25PM +0300, Tiago Vignatti wrote:
> > This patch implements the option of a server without support for vga
> > arbitration, using dummy functions. It introduces --{enable, disable}-vgaarb
> > to autoconf (enabled by default).
> > 
> > Note that the server now requires libpciaccess >= 0.10.8.
> > 
> > Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> > ---
> > 
> > What about this one, Dave? I don't know if this way is how you thought. Well,
> > here are the stats:
> > 
> > - with vgaarbiter
> >    text    data     bss     dec     hex filename
> > 1658395   48164   43756 1750315  1ab52b /opt/master/bin/Xorg
> > 
> > - without vgaarbiter and with dummy functions we got .7411 % of text removal:
> >    text    data     bss     dec     hex filename
> > 1646105   48008   43756 1737869  1a848d /opt/master/bin/Xorg
> > 
> > - without vgaarbiter with ugly macros (previous patch) all over the code we 
> >   got .7657 % of text removal:
> >    text    data     bss     dec     hex filename
> > 1645698   47976   43756 1737430  1a82d6 /opt/master/bin/Xorg
> > 
> > So it's far from being an extraordinary removal but IMHO already justifies.
> 
> Judging from the irc conversation following this patch it looks like we need
> an option to disable the whole bus, not just the arbiter.
> Since you yourself mentioned this is ongoing, I'd rather you wait and merge
> it when it applies to everything to avoid having a zillion options.

Agreed.

Peter, I think it lasts only "[PATCH 2/3] xfree86: vgaarb: rework wrapping
function" now. Care to apply? (off course, don't rush, this is cleanup and not
bug fix)


Thanks,
            Tiago