xf86dgaproto: Changes to 'master'

Carl Worth cworth at cworth.org
Wed Sep 16 21:09:49 PDT 2009

Excerpts from Julien Cristau's message of Wed Sep 16 16:06:38 -0700 2009:
> >     Add back xf86dga.h (simply including the newly named xf86dgaconst.h)
> >     
> >     This maintains compatibility so that previous X servers, (such as
> >     xserver 1.6 can still be built).
> > 
> Hi Carl,
> this change seems wrong, since xf86dga.h moved to libXxf86dga
> (http://cgit.freedesktop.org/xorg/lib/libXxf86dga/commit/?id=e28cffbe48279a622b1
> 9cab1c83ab0a97e60ccef).
> Now we get two conflicting versions of this header.

Ah, yes.

So my change was a bit incomplete. I think we do want this header to
be owned by the proto package, so that we can still build xserver 1.6
say, (good for bisecting). So we just need to fix the library, (by
renaming its header, and making sure that xf86dga.h includes *that*
header when not building the server).

This should give us compatibility with everything, while still leaving
the benefit that all of the non-protocol content is moved out of the
proto package and into the library.

I've got two commits (one to xf86dgaproto and one to libXxf86dga) that
seem to work fine for this. I'll follow up with those here, and wait
to see if they get any negative feedback before pushing them.

If we run into any other similar compatibility problems we should be
able to address them in similar ways.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090916/858e6dc8/attachment.pgp 

More information about the xorg-devel mailing list