[PATCH] render: return the supported version rather than just passing the proto's version

Julien Cristau jcristau at debian.org
Thu Sep 17 04:24:43 PDT 2009

On Tue, Sep 15, 2009 at 13:30:54 +1000, Peter Hutterer wrote:

> This is a problem that affects a number of protocols:
> - updating the protocol and recompiling the server makes it announce a
>   false version.
> - updating the server but not the protocol makes it announces a false
>   version.
> - having a separate server define means over time we will forget to update
>   it (libXcomposite has seen this effect already).
> only the second issue is currently prevented by pkgconfig.
> This define only fixes the issue for now, I'd rather see a solution that
> addresses this issue properly and for all protocol repos.
> Though I'm not sure yet how that solution should look like.
The first issue seems more important to me, so I thought it was worth
addressing even if we don't fix everything at once.  Announcing a too
small version doesn't break anything, it just reduces functionality.
Announcing a version you don't actually support means correct apps get
BadRequest errors.


More information about the xorg-devel mailing list