[PATCH] dix: In MakeWindowOptional: Fix crash if parentOptional->cursor is NULL.

[Kim Woelders]

On Mon, 28 Sep 2009 20:48:52 +0200, Daniel Stone <daniel at fooishbar.org>  
wrote:

> On Mon, Sep 28, 2009 at 07:47:46PM +0200, Kim Woelders wrote:
>> On Mon, 28 Sep 2009 01:28:24 +0200, Peter Hutterer
>> <peter.hutterer at who-t.net> wrote:
>> > try testing with -noreset, as Julien said the regeneration support was
>> > busted in the driver. If you see crashes that happen outside of a  
>> regen,
>> > that'd be serious.
>> >
>> Thanks, I updated to the intel driver from git and this problem seems to
>> be gone.
>>
>> Next reliable crash, although a bit harder to trigger, is this:
>>
>> Start server. Start xterm. Start gqview and kill it "immediately",  
>> repeat
>> start/kill gqview until server crash:
>>
>> Program received signal SIGPIPE, Broken pipe.
>> [...]
>>
>> It can be triggered with other apps than gqview but with gqview it is
>> fairly easy.
>>
>> Any suggestions?
>
> SIGPIPE isn't a crash, it just means that you're writing to a client
> which has since exited.  The server handles this gracefully, so you can
> just ignore SIGPIPE.
>
Aargh! Of course. Apologies again :(

Ok, here is a "good" one, I hope. After starting and killing attached  
program twice I get:

Program received signal SIGSEGV, Segmentation fault.
0x08070cc4 in LoadGlyphs (data=<value optimized out>,
     item_size=<value optimized out>, nchars=<value optimized out>,  
pfont=0xc1a5288,
     client=0xc15eab8) at dixfonts.c:118
118         if (fpe_functions[pfont->fpe->type].load_glyphs)
Missing separate debuginfos, use: debuginfo-install expat-2.0.1-7.i686  
freetype-2.3.9-6.fc12.i686 keyutils-libs-1.2-6.fc12.i686  
krb5-libs-1.7-8.fc12.i686 libattr-2.4.43-4.fc12.i686  
libcap-2.16-5.fc12.i686 libcom_err-1.41.9-3.fc12.i686  
libfontenc-1.0.5-2.fc12.i686 libgcc-4.4.1-17.i686  
mesa-dri-drivers-7.6-0.13.fc12.i686  
xorg-x11-drv-evdev-2.2.99-8.20090923.fc12.i686  
xorg-x11-drv-fbdev-0.4.1-1.fc12.i686  
xorg-x11-drv-synaptics-1.1.99-7.20090907.fc12.i686  
xorg-x11-drv-vesa-2.2.1-1.fc12.i686
(gdb) bt
#0  0x08070cc4 in LoadGlyphs (data=<value optimized out>,
     item_size=<value optimized out>, nchars=<value optimized out>,  
pfont=0xc1a5288,
     client=0xc15eab8) at dixfonts.c:118
#1  doImageText (data=<value optimized out>, item_size=<value optimized  
out>,
     nchars=<value optimized out>, pfont=0xc1a5288, client=0xc15eab8)
     at dixfonts.c:1504
#2  0x08070fc8 in ImageText (client=<value optimized out>,
     pDraw=<value optimized out>, pGC=<value optimized out>,
     nChars=<value optimized out>, data=<value optimized out>,
     xorg=<value optimized out>, yorg=<value optimized out>,
     reqType=<value optimized out>, did=<value optimized out>) at  
dixfonts.c:1623
#3  0x0806c436 in ProcImageText16 (client=<value optimized out>) at  
dispatch.c:2408
#4  0x0806e167 in Dispatch () at dispatch.c:445
#5  0x08062855 in main (argc=<value optimized out>, argv=<value optimized  
out>,
     envp=<value optimized out>) at main.c:285
(gdb)

Comment out the XCreateGC line and it doesn't crash...

/Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xfs.c
Type: text/x-csrc
Size: 1227 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090928/cc1f890f/attachment.c