[PATCH] dix/glx/composite: fixup colormap visuals correctly.

Keith Packard keithp at keithp.com
Mon Sep 28 15:58:31 PDT 2009

Excerpts from Dave Airlie's message of Sun Sep 27 19:40:57 -0700 2009:

> Guess what, it was right, installed colormaps are useless information
> due to render installing a bunch, this meant every so often we'd have
> a colormap pointing at a visual that wasn't there anymore since the
> realloc moved it, then we'd free the colormap on server exit and
> explode.

Ok, looks like the general plan is correct, but I'd rather see a
single function that reallocates the screen visual array, fixes the
colormaps and then assigns the screen visual pointer at the
end. Having this code duplicated across two modules seems fragile.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090928/2e3e77c3/attachment.pgp 

More information about the xorg-devel mailing list