[PATCH] dix/glx/composite: consolidate visual resize in one place.

Keith Packard keithp at keithp.com
Mon Sep 28 18:24:32 PDT 2009

Excerpts from Dave Airlie's message of Mon Sep 28 16:30:45 -0700 2009:
> The previous code was copied and in both cases incorrectly fixed
> up the colormaps after resizing the visuals, this patch consolidates
> the visual resize + colormaps fixups in one place.

Looks like this function should also allocate space for the new visual
ids somehow? That's still duplicated, and not freed correctly in
failure paths.

> I'm not 100% sure colormap.[ch] is the correct place for this but
> visuals are mostly created in fb and I know thats not the place to
> be resizing them.

Yeah, colormap.c is a fine place for this.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090928/92b4426c/attachment.pgp 

More information about the xorg-devel mailing list