[PATCH v2] render: Fix crash in RenderAddGlyphs (#23645)

Keith Packard keithp at keithp.com
Tue Sep 29 22:29:31 PDT 2009

Excerpts from Peter Hutterer's message of Tue Sep 29 22:15:21 -0700 2009:

> miGlyphs seems to deal with 0-width glyphs just fine

I guess I don't understand how this can be --
ProcRenderCompositeGlyphs passes all of the glyphs to CompositeGlyphs
which just calls down to the Glyphs function. If that is miGlyphs,
you've got a loop that looks like:

	while (n--)
	    glyph = *glyphs++;
	    pPicture = GlyphPicture (glyph)[pScreen->myNum];
	    (uses of pPicture)

I don't see how pPicture won't end up as NULL for zero-sized glyphs,
which should yield a nice segfault.

Am I missing something obvious here?

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20090929/72395fb1/attachment.pgp 

More information about the xorg-devel mailing list