[RFC PATCH] Initial libudev input-hotplug support

Peter Hutterer peter.hutterer at who-t.net
Wed Sep 30 02:19:40 PDT 2009


On Wed, Sep 30, 2009 at 10:17:47AM +0200, Julien Cristau wrote:
> On Wed, Sep 30, 2009 at 08:47:27 +0200, Rémi Cardona wrote:
> 
> > Hi Julien,
> > 
> > Le mardi 29 septembre 2009 à 23:54 +0200, Julien Cristau a écrit :
> > > If libudev is found, we use that for hotplug and disable the hal and
> > > dbus backends.
> > 
> > Why disable dbus? I see udev being in conflict with HAL, but not with
> > the dbus code.
> 
> Yeah, I could do that.

I'd say don't. The dbus-api is disabled by default, we don't encourage
anyone using it, it's virtually untested so I'd say it's best to let it rest
with HAL.

> > uses the dbus interfaces anyway. Maybe it's time to ditch it?
> > 
> [...]
> > > +
> > > +#define UDEV_PROP_KEY "x11_options."
> > > +#define UDEV_XKB_PROP_KEY "xkb."
> > 
> > <harmless bikeshedding>
> > Why not merge the 2 into a single :
> > 
> > UDEV_PROP_KEY "xorg."
> > </bikeshedding>
> > 
> > I think the "xkb" HAL keys were deprecated in favor of
> > "x11_options.Xkb*", let's at least drop the deprecated one.
> > 
> Well my understanding was that input.xkb.foo was preferred.  There's
> nothing strictly x11-specific to the xkb keys (we use the
> xkeyboard-config data files to set the console keymap, e.g.).

input.x11_options.Xkb* overrides input.xkb.*, the latter of which is
usually set by the system configuration. I'm afraid we'll have to support
both.
 
Cheers,
  Peter


More information about the xorg-devel mailing list