Fwd: SIS USB Driver Patch

[Burton Samograd]

Hello,

I attempted to send this patch to the SIS USB driver author as listed
in the sources, and since I was unable to recieve a reply I am
forwarding it to this list in hopes that it can be applied to the
driver source by a maintainer.  Please see the message below for
comments on what the patch fixes.

I am not subscribed to this list so any replies should be sent back to
me directly.

--
Burton Samograd


---------- Forwarded message ----------
From: Burton Samograd <burton.samograd at gmail.com>
Date: Thu, Mar 25, 2010 at 2:31 PM
Subject: SIS USB Driver Patch
To: thomas at winischhofer.net


Hello Thomas,

I noticed that you are the developer and maintainer of the SIS USB
Xorg driver.  I am reading the source code to learn about Xorg driver
development, and I think I came across a minor bug in the code during
the initialization phase (in SISUSBProbe).  I have attached a patch
which should fix the problem.  It is short and should be self
explanitory; it seems that when you were calling xf86ClaimNoSlot you
were using the wrong index into the devSections array.  The patch
stores the correct index while doing the device probe and uses it to
reference the correct devSection when claiming the slot.

I am new to Xorg driver development but this looked like a clear
enough problem that I should attempt to fix it.   Hopefully my
solution is correct and it can be applied to the driver code.  I am
currently reading version 0.9.3 of the driver code.

If you are not the current maintainer of the driver, could you please
direct me towards the new maintainer so I can attempt to send them
this patch?

Thank you.

--
Burton Samograd
burton.samograd at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sisusb_driver.c.diff-u.patch
Type: application/octet-stream
Size: 1734 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100407/1e85e800/attachment.obj>