[PATCH xinit] Simplify environment juggling by using fork() instead of vfork()

[Mikhail Gusarov]

Twas brillig at 08:31:41 13.04.2010 UTC-07 when alan.coopersmith at oracle.com did gyre and gimble:

 >> +        if (!setenv("WINDOWPATH", newwindowpath, TRUE)) {
 >> +            free(newwindowpath);
 >> +            return;
 >> +        }
 >> +
 >> +        free(newwindowpath);
 >>  }

 AC> Unless I'm missing something, both cases of the if result in the
 AC> same code - free + return.  I could see printing an error message
 AC> or something in the failure case, but then both should go to the
 AC> same free/return code.

Hah, really.

 AC> Also, if we're no longer using HAVE_WORKING_VFORK & friends, then
 AC> you should also delete the AC_FUNC_FORK line from configure.ac

 AC> A couple formatting issues I note:

 AC> git am warned of a trailing whitespace issue when applying:
 AC>   .dotest/patch:106: trailing whitespace.
 AC>                 snprintf(newwindowpath, len, "%s:%s",

There's still lot of trailing whitespace in file. I tried to avoid
touching it.

 AC> It also seems like you've changed the indentation in startClient()
 AC> to not match the rest of the file (which appears to be 1 tab per
 AC> indent level mostly).  Though we have no consistent project-wide
 AC> style, we try to keep each source file consistent with itself at
 AC> least, to avoid really hurting our brains when reading them.

I want to work on it further (rewrite in XCB actually - damn the
WINDOWPATH handling, it's the only part which needs Xlib) and convert to
server's 4-spaces-indent.

Not sure how to do it properly - last "fix the whitespace" patch caused
some confusion.

Is it okay to rework it into patch series, starting with [PATCH 1/x]
"reindent this stuff"?

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100413/2bc5e8c1/attachment.pgp>