[PATCH] Revert "Revert "Render: Use built-in SHA1 library""

Alan Coopersmith alan.coopersmith at oracle.com
Tue Apr 13 10:41:39 PDT 2010


Carl Worth wrote:
> It does seem to me that it would be useful to have a tiny library that
> just did SHA1. Then it could be packaged in the distributions, both the
> X server and notmuch could use it, and everyone could be happy.

Like the libmd library that the BSD & Solaris cases use in the current
configure.ac?

-rwxr-xr-x   1 root     bin      1536684 Mar  4 14:31 libcrypto.so.0.9.8*
-rwxr-xr-x   1 root     bin        87544 Mar  4 14:32 libmd.so.1*

It's not Xorg's fault if the Linux distros haven't picked it up yet.

Tiago Vignatti wrote:
> Ideally I'd try to analyse some eventual performance regressions on
> render. Do you guys think we should care with this? Carl?

Which is one of the reasons I prefer libmd over our own copy of the code.
libmd already has the optimizations for all the various CPU variants - the
small, simple copy of SHA1 in Xorg doesn't stay small & simple once you
start attacking performance and adding in CPU-tuned versions.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list