[PATCHv2 2/2] glx: Drop DestroyWindow hook

[Michel Dänzer]

On Thu, 2010-04-15 at 07:58 -0400, Kristian Høgsberg wrote: 
> 2010/4/15 Michel Dänzer <michel at daenzer.net>:
> > On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote:
> >>
> >> The real fix is the patch from attachment 25038, not the DestroyWindow
> >> hook.  If the context is destroyed first, it will remove itself from
> >> the glxAllContexts list so the DrawableGone destructor won't touch it.
> >>  On the other hand, if the drawable is destroyed first, thanks to your
> >> patch, it will detach itself from the context properly so context
> >> destruction (whether at resource cleanup time or at client shutdown
> >> time) wont touch a free drawable.
> >
> > Right, but that will only work if DestroyWindow of the X window also
> > destroys the corresponding GLX drawable. Are you saying that's
> > guaranteed anyway now, and have you tested that none of MacSlow's
> > rgba-glx demos crashes the X server on exit anymore without this hook?
> 
> Yes, the GLX drawable is a client allocated resource that gets cleaned
> up when the client exits.

And if it doesn't? :) What's to stop a client from binding a window to a
GLX context, destroying the X window and then doing more stuff with the
GLX context?


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer