[PATCH] xfree86: fix not reached code in tty code

Peter Hutterer peter.hutterer at who-t.net
Mon Apr 19 17:34:18 PDT 2010


On Mon, Apr 19, 2010 at 08:58:08PM +0300, Tiago Vignatti wrote:
> CLEARRTS_SUPPORT cannot be triggered at all.
> 
> Both commit logs and google don't show any clear reference about it, so I'd
> vote to just delete.

man mousedrv

I'd leave the else branch there.

> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
>  hw/xfree86/os-support/shared/posix_tty.c |   13 -------------
>  1 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/hw/xfree86/os-support/shared/posix_tty.c b/hw/xfree86/os-support/shared/posix_tty.c
> index 4ba8599..f77f902 100644
> --- a/hw/xfree86/os-support/shared/posix_tty.c
> +++ b/hw/xfree86/os-support/shared/posix_tty.c
> @@ -338,19 +338,6 @@ xf86SetSerial (int fd, pointer options)
>  		xf86MarkOptionUsedByName (options, "ClearDTR");
>  	}
>  
> -	if ((xf86SetBoolOption (options, "ClearRTS", FALSE)))
> -	{
> -#ifdef CLEARRTS_SUPPORT
> -		val = TIOCM_RTS;
> -		SYSCALL (ioctl(fd, TIOCMBIC, &val));
> -#else
> -		xf86Msg (X_WARNING,
> -			 "Option ClearRTS not supported on this OS\n");
> -			return (-1);
> -#endif
> -		xf86MarkOptionUsedByName (options, "ClearRTS");
> -	}
> -
>  	SYSCALL (r = tcsetattr (fd, TCSANOW, &t));
>  	return (r);
>  }
> -- 
> 1.6.0.4




More information about the xorg-devel mailing list