[PATCH] Revert "mi: don't thrash resources when displaying the software cursor across screens"

[Aaron Plattner]

On Wed, Apr 21, 2010 at 08:36:59PM -0700, Keith Packard wrote:
> On Wed, 21 Apr 2010 16:51:17 -0700, "Pierre-Loup A. Griffais" <pgriffais at nvidia.com> wrote:
>
> > Since the revert is already pushed, here's a new version of the change as Peter
> > pushed it including the teardown crash fix.
>
> Is this fixing some known issue? Or is it just that it seems sub-optimal
> to change things around when drawing the sprite to a different screen?

Yes, it fixes a server crash when the cursor crosses screens.  From the
original thread [1]:

On Mon, 2010-04-05 at 18:52 -0700, Pierre-Loup A. Griffais wrote:
> The DC code is broken for setups with several screens. Devs only have one
> pSave pixmap and there's no code to thrash them like p[Save|Restore]GC.
>
> That means if you have two X screens and force SW cursor on both, the
> server will end up passing a bunch of CopyAreas with mismatching screens
> to the driver, which can fail horribly if the driver does a good job
> abstracting screens away from each other.

It's the "CopyAreas with mismatching screens" that are the problem.

[1]: http://lists.x.org/archives/xorg-devel/2010-April/006874.html