[PATCH] Refactoring of dixutils.c

[Tiago Vignatti]

On Fri, Jul 30, 2010 at 11:16:43PM +0200, ext Fernando Carrijo wrote:
> So, here is the result of my preliminary attempt to bring some order to dix. The
> refactoring of the messy dixutils.c into more cohesive files sounded like a good
> oportunity for me to experiment with the code, and that's what the following
> statistics are about:
> 
>    [PATCH 1/7] dix: Extract blockhandler.c from within dixutils.c
>    [PATCH 2/7] dix: Extract callback.c from within dixutils.c
>    [PATCH 3/7] dix: Extract lookup.c from within dixutils.c
>    [PATCH 4/7] dix: Extract sleepqueue.c from within dixutils.c
>    [PATCH 5/7] dix: Extract workqueue.c from within dixutils.c
>    [PATCH 6/7] dix: dixutils.c doesn't need those headers anymore. Remove them.
>    [PATCH 7/7] dix: Cleanup dix.h to match the refactoring suffered by dixutils.c
> 
>    dix/Makefile.am    |    7 +-
>    dix/blockhandler.c |  233 +++++++++++++++++++
>    dix/callback.c     |  322 ++++++++++++++++++++++++++
>    dix/dixutils.c     |  643 ----------------------------------------------------
>    dix/lookup.c       |  183 +++++++++++++++
>    dix/sleepqueue.c   |  173 ++++++++++++++
>    dix/workqueue.c    |  166 ++++++++++++++
>    include/dix.h      |   51 +++--
>    8 files changed, 1111 insertions(+), 667 deletions(-)
> 
> This patch series adds no functional changes to dix whatsoever, and the mismatch
> between the number of lines added and removed can be explained by the replication
> of copyright messages in the newly created files.

I do agree with these changes: 

Acked-by: Tiago Vignatti <tiago.vignatti at nokia.com>

I'm looking forward now to see proto/ created, as discussed.


Thanks,

             Tiago