[PATCH] xfree86: Loader: Don't print loader 'magic'.

Adam Jackson ajax at nwnk.net
Mon Aug 2 08:57:10 PDT 2010


On Sun, 2010-08-01 at 16:01 -0700, Jesse Adkins wrote:
> xorg_symbols has nothing to do with module loading.
> Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>

Be very very careful in doing this.  I'm inclined to nak this on
principle.

The issue is that some symbols need to be included in the server so they
can be exported to drivers.  This is why we have a big table referencing
them all.  The problem then is making sure the _table_ is referenced,
otherwise the linker can GC it away (and then GC away all the symbols it
references...).  Passing it to a print function is enough of a side
effect to make sure it sticks around in the final link.

There is assuredly a better way to do this for sensible toolchains, but
instead we're using libtool.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100802/7831071f/attachment.pgp>


More information about the xorg-devel mailing list