[PATCH] xfree86 : Purge vgaCmap.c from vgaHW.

[Adam Jackson]

On Mon, 2010-08-02 at 14:26 +1000, Peter Hutterer wrote:
> On Sun, Aug 01, 2010 at 04:01:30PM -0700, Jesse Adkins wrote:
> > The functions within are not exported by vgaHW, so nobody is using them.
> > 
> > Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>
> > ---
> >  hw/xfree86/vgahw/Makefile.am |    2 +-
> >  hw/xfree86/vgahw/vgaCmap.c   |  301 ------------------------------------------
> >  2 files changed, 1 insertions(+), 302 deletions(-)
> >  delete mode 100644 hw/xfree86/vgahw/vgaCmap.c
> > 
> > diff --git a/hw/xfree86/vgahw/Makefile.am b/hw/xfree86/vgahw/Makefile.am
> > index f48e46a..5ff96db 100644
> > --- a/hw/xfree86/vgahw/Makefile.am
> > +++ b/hw/xfree86/vgahw/Makefile.am
> > @@ -6,4 +6,4 @@ AM_CFLAGS = $(DIX_CFLAGS) $(XORG_CFLAGS)
> >  
> >  sdk_HEADERS = vgaHW.h
> >  
> > -EXTRA_DIST = vgaCmap.c
> > +EXTRA_DIST = 
> 
> can't you just remove this line then?

Yep.

> not sure about the rest, needs someone else to ack/nak it based on whether
> this is still relevant.

It appears that the last time this was live code was before a David
Dawes commit on 22 November 1998, when (apparently) vgaHWHandleColormaps
was fixed for 4bpp.  Then on 29 November 1998 vgaCmap.c was removed from
the vgahw module build, and has been sitting rotten ever since.

In other words, that's been dead code for the entire lifetime of XFree86
4.x, let alone Xorg releases.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100802/bf52cd9a/attachment.pgp>