[PULL] input fixes for 1.9, unloved.

[Keith Packard]

On Tue, 10 Aug 2010 12:04:35 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> >     xkb: post-fix PointerKeys button events with a DeviceChangedEvent.
> > exposed by 14327858391ebe929b806efb53ad79e789361883, devices with more
> > valuators than the XTEST pointer device now skip events.

Where is the first DCE event coming from? And, how about
FakePointerMotion? Does that need DCE afterwards as well? You realize
these code paths are a disaster, right?

> >       xkb: if the button isn't down, don't fake an event.
> > not strictly necessary for 1.9 but saves us a lot of effort, given that the
> > ratio of physical releases to required XTEST releases is about a million to
> > one.

Seems reasonable to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

> >       Xi: reset the unused classes pointer after copying
> > fixes a bug exposed by the first patch above.

If the other patch exposes a bug, then this patch should be applied
first.

Reviewed-by: Keith Packard <keithp at keithp.com>

(I think I might even understand this -- the unused_classes essentially
holds structures that might be used when flipping devices around)

> > Patches have been on the list, rumours have it the few people who looked at
> > them ran away screaming before throwing Reviewed-by tags my way.

I'm with them.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100809/136bd569/attachment-0001.pgp>