[PATCH] rootless: fix uninitialized private key assert in non-rootless modes on cygwin

Jon TURNEY jon.turney at dronecode.org.uk
Tue Aug 10 03:38:00 PDT 2010


On 10/08/2010 05:33, Keith Packard wrote:
> On Sat,  7 Aug 2010 14:32:26 +0100, Jon TURNEY<jon.turney at dronecode.org.uk>  wrote:
>
>> +    if (!rootlessWindowPrivateKeyRec.initialized)
>> +        return FALSE;
>> +
>
> Please use the function 'dixPrivateKeyRegistered' instead of looking
> inside the structure.

Thanks for pointing out the existence of that function. Amended patch attached.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-rootless-fix-uninitialized-private-key-assert-in-non.patch
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100810/d4a1dbf9/attachment.asc>


More information about the xorg-devel mailing list