[PATCH,HURD] Fix use of deprecated iopl device

olafBuddenhagen at gmx.net olafBuddenhagen at gmx.net
Mon Aug 9 15:02:58 PDT 2010


Hi,

On Sun, Aug 01, 2010 at 09:28:43PM +0200, Samuel Thibault wrote:

> This fixes Xserver on GNU/Hurd into using the "mem" device instead of
> the deprecated "iopl" device.

The patch looks fine (it's trivial enough); however:

> -    mach_port_t device,iopl_dev;
> -    memory_object_t iopl_mem;
> +    mach_port_t device,mem_dev;
> +    memory_object_t mem_mem;

mem_mem is a rather weird variable name. Perhaps you could rename it to
something clearer? Maybe mem_object...

-antrik-


More information about the xorg-devel mailing list