[PATCH] DeepCopyPointerClasses should not copy kbdfeed->CtrlProc
Alan Coopersmith
alan.coopersmith at oracle.com
Thu Aug 12 00:09:00 PDT 2010
The pointer drivers that have anything other than a no-op there assume
the device passed to CtrlProc on has their flavor of devicePrivate,
which the Virtual Core Pointer won't.
Fixes Solaris bug 6950572:
X mouse driver crashes Xorg during unplug-plug the usb mouse device
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6950572
Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
Leaves the open question of whether any of Xi's DeepCopy* functions should
be copying the CtrlProc pointers or if the ones for other device classes
make similar assumptions.
Xi/exevents.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/Xi/exevents.c b/Xi/exevents.c
index e990aeb..02e5d57 100644
--- a/Xi/exevents.c
+++ b/Xi/exevents.c
@@ -520,7 +520,6 @@ DeepCopyPointerClasses(DeviceIntPtr from, DeviceIntPtr to)
return;
}
}
- (*p)->CtrlProc = it->CtrlProc;
(*p)->ctrl = it->ctrl;
p = &(*p)->next;
--
1.5.6.5
More information about the xorg-devel
mailing list