[PATCH:xf86-input-mouse] MouseCtrl doesn't need to save values we never use
Alan Coopersmith
alan.coopersmith at oracle.com
Sat Aug 14 01:07:22 PDT 2010
Simon Thum wrote:
> Am 12.08.2010 06:43, schrieb Alan Coopersmith:
>> Makes it into a no-op, like evdev's PtrCtrl function, now that
>> mouse acceleration is completely handled in dix.
>
> Reviewed-by: Simon Thum <simon.thum at gmx.de>
>> + /* This function intentionally left blank */
>
> AFAIK that's the implementation approach pretty much every driver sports
> today, so next time one breaks ABI this might be dumped altogether.
That was what we discussed on IRC, and I hinted at in the xserver patch
to stop calling the functions - there are several other input drivers that
attempt to do things in their pointer feedback control callbacks, but none
that seemed to do anything actually useful.
--
-Alan Coopersmith- alan.coopersmith at oracle.com
Oracle Solaris Platform Engineering: X Window System
More information about the xorg-devel
mailing list