[PATCH] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC in Xorg

ykzhao yakui.zhao at intel.com
Mon Aug 23 17:55:22 PDT 2010


On Tue, 2010-08-24 at 08:32 +0800, ykzhao wrote:
> On Mon, 2010-08-23 at 23:25 +0800, Adam Jackson wrote:
> > On Mon, 2010-08-23 at 10:23 +0200, Mark Kettenis wrote:
> > > > From: yakui.zhao at intel.com
> > > > Date: Mon, 23 Aug 2010 15:20:05 +0800
> > > > From: Zhao Yakui <yakui.zhao at intel.com>
> > > > 
> > > > ---
> > > >  os/utils.c |   14 +++++++++++++-
> > > >  1 files changed, 13 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/os/utils.c b/os/utils.c
> > > > index 51455cc..a08d591 100644
> > > > --- a/os/utils.c
> > > > +++ b/os/utils.c
> > > > @@ -242,6 +242,10 @@ OsSignal(int sig, OsSigHandlerPtr handler)
> > > >  #endif
> > > >  #endif
> > > >  
> > > > +#ifndef CLOCK_MONOTONIC_COARSE
> > > > +#define CLOCK_MONOTONIC_COARSE 6
> > > > +#endif
> > > 
> > > What if an OS doesn't have CLOCK_MONOTONIC_COARSE, but uses the clock
> > > ID 6 for some other purpose?
> > 
> > Then this patch would be wrong.
> > 
> > NAK on that basis.
> 
> Yes. Agree.
> 
> How about using the constant value(6) directly? 

Sorry that I misunderstand it.(I misunderstand it as the incorrect macro
definition.)

What Mark mentioned is that the CLOCK_MONOTONIC_COARSE posix timer is
not supported while the corresponding ID is used for other posix timer.
Right? 

If so, is there an approach that helps us to detect whether the
CLOCK_MONOTONIC_COARSE posix timer is supported on one OS?

Thanks.

> 
> > 
> > - ajax
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



More information about the xorg-devel mailing list