[PATCH] xfree86: use a thread for the generation of input events

Alan Coopersmith alan.coopersmith at oracle.com
Mon Aug 23 21:16:39 PDT 2010


Tiago Vignatti wrote:
> The current SIGIO signal handler method, used at generation of input events,
> has a bunch of oddities. This patch introduces an alternative way using a
> thread, which is used to select()s all input device file descriptors.

Don't you have to make sure you use the right CFLAGS & LDFLAGS for pthreads?
Something like the XTHREADLIB & XTHREAD_CFLAGS settings in libX11/configure.ac.

You may be getting them by accident now, via this bit of the xserver configure.ac:
if test "x$GLX_USE_TLS" = xyes -a "x$AIGLX" = xyes; then
        GLX_DEFINES="-DGLX_USE_TLS -DPTHREADS"
        GLX_SYS_LIBS="$GLX_SYS_LIBS -lpthread"
fi

But that doesn't match the flags used by libX11 on several platforms
(-lpthread vs. -pthread on some BSD's, missing -D flags for posix threads
on NetBSD, FreeBSD, & Solaris - though using those may reduce performance
on those platforms as all calls get redirected to thread-safe versions).

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list