[PATCH xserver] config: remove --with-dri-driver-path option, use dri.pc #29740

[Dan Nicholson]

On Tue, Aug 24, 2010 at 2:12 PM, Kristian Høgsberg <krh at bitplanet.net> wrote:
> 2010/8/24 Gaetan Nadon <memsize at videotron.ca>:
>> On Tue, 2010-08-24 at 12:56 +0200, Michel Dänzer wrote:
>>
>> Could just use dri.pc for the default value of the option, rather than
>> removing it altogether?
>>
>> Yes. I think the author of the bug report wishes to also remove the option
>> as it is no longer useful.
>>
>> This is an opportunity for me to get the real story being this type of
>> option. There are many in the server but also in other modules. It looks to
>> me that in the past there were no pkg-config infrastructure (or it was not
>> used or not mature) so there had to be an option for every directory a
>> module needed to know.
>>
>> Once a directory is published through pkg-config, there is no longer a need
>> to ask the user for its value. I suspect it is even wrong to allow the user
>> to specify one as there cannot be 2 directories for the same stuff.
>
> I added the option in c3342c8000f6d2bfb61e2cf95e028d11b59698fa in
> 2004.  At the time we didn't have dri.pc.  I don't see a reason to
> keep it now.

To me, the only reason is that since you can't override the path at
runtime either, there's no way to set a custom path to the modules.
Maybe that's more of a runtime concern, though.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>