[PATCH 5/6] xfree86: fbdevhw: move PCI region fetching code to common pci file

[Mark Kettenis]

> Date: Thu, 26 Aug 2010 21:59:58 +0300
> From: Tiago Vignatti <vignatti at freedesktop.org>
> 
> 2010/8/26 Mark Kettenis <mark.kettenis at xs4all.nl>:
> >> From: Tiago Vignatti <tiago.vignatti at nokia.com>
> >> Date: Thu, 26 Aug 2010 18:37:33 +0300
> >>
> >> Now xf86PciGetSize and xf86PciGetBaseAddr are used to fetch PCI regions.
> >
> > Do you have plans for these functions to be used in other parts of the
> > server, or export them to the drivers?
> 
> the idea is to make the whole server free from PCI dependency, in a
> way that we can choose or not to build with. I see that separating PCI
> related code in a file/directory that concerns only it is a way.
> 
> Do you have another suggestion how to do so?

Sorry, but I think that on systems that support PCI framebuffers, the
fbdevhw module is intrinsically tied to it.  Moving the PCI code out
of the fbdevhw module, makes the code more difficult to understand.

If you're really interested on supporting the fbdevhw module on
PCI-less systems (or at least systems where graphics will never be on
PCI), I think you should add #ifdefs to the fbdevhw code to make clear
which bits are only needed to support PCI framebuffers.

If you don't need the fbdevhw module at all on those systems, I think
you should work towards making the whole module optional.