[PATCH 0/1] os: Return BadLength instead of disconnecting BigReq clients (#4565)
Aaron Plattner
aplattner at nvidia.com
Fri Aug 27 01:21:52 PDT 2010
This change fixes a lot of XTS Xproto tests that use the TOO_LONG test
mode. This mode sends a request with a length that's too large and then
expects a BadLength error. Instead, when the server supports big requests,
it just gets disconnected and receives a SIGPIPE instead. The test suite
flags that as UNRESOLVED, which counts as an error.
Here is the summary from before the change:
VSW5 SUMMARY RESULTS REPORT
Test suite version: 5.1.5
Specification version: Open Group Window Management (X11R5) document set
Test run by: aaron
System: Linux weasel 2.6.34-ARCH #1 SMP PREEMPT Mon Jul 5 22:12:11 CEST 2010 x86_64
Test run started: Thursday August 26, 2010 10:28:58 PM
Test run ended: Thursday August 26, 2010 11:03:19 PM
Journal file: results/2010-08-26-22:28:58/journal
TCC command line: /home/aaron/git/x/xts/src/tet3/tcc/.libs/lt-tcc -e -i results/2010-08-26-22:28:58 -x ./xts5/tetexec.cfg xts5
Report type: -d 2 -s 1
282 TCC errors occurred
CASES TESTS PASS UNSUP UNTST NOTIU WARN FIP FAIL UNRES UNIN ABORT
Xproto 122 389 249 2 0 0 0 0 18 120 0 0
Xlib3 109 161 129 3 26 1 0 0 2 0 0 0
Xlib4 29 324 286 11 20 5 0 0 2 0 0 0
Xlib5 15 84 77 2 5 0 0 0 0 0 0 0
Xlib6 8 50 20 0 30 0 0 0 0 0 0 0
Xlib7 58 172 144 9 13 0 0 0 5 1 0 0
Xlib8 29 165 133 10 22 0 0 0 0 0 0 0
Xlib9 46 1472 1197 23 36 201 8 0 7 0 0 0
Xlib10 23 95 56 1 36 0 0 0 1 1 0 0
Xlib11 33 195 122 22 4 43 0 0 2 2 0 0
Xlib12 27 138 106 2 15 12 0 0 3 0 0 0
Xlib13 32 269 225 3 10 3 0 0 21 7 0 0
Xlib14 45 58 46 0 5 0 0 0 7 0 0 0
Xlib15 45 159 121 0 33 0 0 0 5 0 0 0
Xlib16 30 105 82 1 22 0 0 0 0 0 0 0
Xlib17 55 131 107 0 19 0 0 0 3 2 0 0
Xopen 8 127 125 2 0 0 0 0 0 0 0 0
Xt3 21 73 0 0 0 0 0 0 0 0 73 0
Xt4 33 192 0 0 0 0 0 0 0 0 192 0
Xt5 10 69 0 0 0 0 0 0 0 0 69 0
Xt6 7 71 0 0 0 0 0 0 0 0 71 0
Xt7 11 106 0 0 0 0 0 0 0 0 106 0
Xt8 7 43 0 0 0 0 0 0 0 0 43 0
Xt9 33 189 0 0 0 0 0 0 0 0 189 0
Xt10 8 17 0 0 0 0 0 0 0 0 17 0
Xt11 58 285 0 0 0 0 0 0 0 0 285 0
Xt12 22 67 0 0 0 0 0 0 0 0 67 0
Xt13 39 178 0 0 0 0 0 0 0 0 178 0
Xt14 2 18 0 0 0 0 0 0 0 0 18 0
Xt15 1 2 0 0 0 0 0 0 0 0 2 0
XtC 29 147 0 0 0 0 0 0 0 0 147 0
XtE 1 1 0 0 0 0 0 0 0 0 1 0
TOTAL 996 5552 3225 91 296 265 8 0 76 133 1458 0
and after:
VSW5 SUMMARY RESULTS REPORT
Test suite version: 5.1.5
Specification version: Open Group Window Management (X11R5) document set
Test run by: aaron
System: Linux weasel 2.6.34-ARCH #1 SMP PREEMPT Mon Jul 5 22:12:11 CEST 2010 x86_64
Test run started: Thursday August 26, 2010 11:24:54 PM
Test run ended: Thursday August 26, 2010 11:59:20 PM
Journal file: results/2010-08-26-23:24:54/journal
TCC command line: /home/aaron/git/x/xts/src/tet3/tcc/.libs/lt-tcc -e -i results/2010-08-26-23:24:54 -x ./xts5/tetexec.cfg xts5
Report type: -d 2 -s 1
282 TCC errors occurred
CASES TESTS PASS UNSUP UNTST NOTIU WARN FIP FAIL UNRES UNIN ABORT
Xproto 122 389 368 2 0 0 0 0 19 0 0 0
Xlib3 109 161 129 3 26 1 0 0 2 0 0 0
Xlib4 29 324 286 11 20 5 0 0 2 0 0 0
Xlib5 15 84 77 2 5 0 0 0 0 0 0 0
Xlib6 8 50 20 0 30 0 0 0 0 0 0 0
Xlib7 58 172 144 9 13 0 0 0 5 1 0 0
Xlib8 29 165 133 10 22 0 0 0 0 0 0 0
Xlib9 46 1472 1197 23 36 201 8 0 7 0 0 0
Xlib10 23 95 56 1 36 0 0 0 1 1 0 0
Xlib11 33 195 122 22 4 43 0 0 2 2 0 0
Xlib12 27 138 106 2 15 12 0 0 3 0 0 0
Xlib13 32 269 225 3 10 3 0 0 21 7 0 0
Xlib14 45 58 46 0 5 0 0 0 7 0 0 0
Xlib15 45 159 121 0 33 0 0 0 5 0 0 0
Xlib16 30 105 82 1 22 0 0 0 0 0 0 0
Xlib17 55 131 107 0 19 0 0 0 3 2 0 0
Xopen 8 127 125 2 0 0 0 0 0 0 0 0
Xt3 21 73 0 0 0 0 0 0 0 0 73 0
Xt4 33 192 0 0 0 0 0 0 0 0 192 0
Xt5 10 69 0 0 0 0 0 0 0 0 69 0
Xt6 7 71 0 0 0 0 0 0 0 0 71 0
Xt7 11 106 0 0 0 0 0 0 0 0 106 0
Xt8 7 43 0 0 0 0 0 0 0 0 43 0
Xt9 33 189 0 0 0 0 0 0 0 0 189 0
Xt10 8 17 0 0 0 0 0 0 0 0 17 0
Xt11 58 285 0 0 0 0 0 0 0 0 285 0
Xt12 22 67 0 0 0 0 0 0 0 0 67 0
Xt13 39 178 0 0 0 0 0 0 0 0 178 0
Xt14 2 18 0 0 0 0 0 0 0 0 18 0
Xt15 1 2 0 0 0 0 0 0 0 0 2 0
XtC 29 147 0 0 0 0 0 0 0 0 147 0
XtE 1 1 0 0 0 0 0 0 0 0 1 0
TOTAL 996 5552 3344 91 296 265 8 0 77 13 1458 0
The only test that went from UNRESOLVED to FAIL is pChangeKeyboardMapping.
More information about the xorg-devel
mailing list