[PATCH libSM] Export only public API symbols

Alan Coopersmith alan.coopersmith at oracle.com
Mon Dec 6 10:08:16 PST 2010


Cristian Rodríguez wrote:
> Signed-off-by: Cristian Rodríguez <cristian.rodriguez at opensuse.org>
> ---
>  src/Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 1098679..d194d3f 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -6,7 +6,7 @@ if WITH_LIBUUID
>  AM_CFLAGS += $(LIBUUID_CFLAGS) -DHAVE_LIBUUID
>  endif
>  
> -libSM_la_LDFLAGS = -version-number 6:0:1 -no-undefined
> +libSM_la_LDFLAGS = -export-symbols-regex "Sm.*" -version-number 6:0:1 -no-undefined
>  
>  libSM_la_LIBADD = $(SM_LIBS) $(XTRANS_LIBS)
>  

This is also exporting all the _Sm.* symbols - was that intentional?
By exporting those, these seems to pretty much be a no-op change, since
that covers all the symbols produced by the library (unless your compiler
generates some exported symbols for builtins or such).

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list