[PATCH xserver (v4) 04/10] Factor out generic code from ProcSyncAwait()

Keith Packard keithp at keithp.com
Mon Dec 6 17:03:05 PST 2010


On Mon, 6 Dec 2010 14:53:18 -0800, James Jones <jajones at nvidia.com> wrote:

> In preparation for adding more sync object types
> that will need Await requests of their own, factor
> out some setup and finalization code from
> ProcSyncAwait() into SyncAwaitPrologue() and
> SyncAwaitEpilogue()
> 
> Signed-off-by: James Jones <jajones at nvidia.com>

> @@ -1525,7 +1569,7 @@ ProcSyncAwait(ClientPtr client)
>  	if (pProtocolWaitConds->counter == None) /* XXX protocol change */
>  	{
>  	    /*  this should take care of removing any triggers created by
> -	     *  this request that have already been registered on counters
> +	     *  this request that have already been registered on sync objects

> @@ -1546,7 +1590,7 @@ ProcSyncAwait(ClientPtr client)
>  	if (status != Success)
>  	{
>  	    /*  this should take care of removing any triggers created by
> -	     *  this request that have already been registered on counters
> +	     *  this request that have already been registered on sync objects

These two changes appear to belong in the previous patch.

Otherwise, this looks like a clean mechanical patch again.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101206/d298b673/attachment.pgp>


More information about the xorg-devel mailing list