[PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

Alan Hourihane alanh at fairlite.co.uk
Wed Dec 8 01:03:12 PST 2010


On Wed, 2010-12-08 at 08:50 +0000, Alan Hourihane wrote:
> On Tue, 2010-12-07 at 23:20 +0000, Matt Turner wrote:
> > On Tue, Dec 7, 2010 at 8:07 PM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
> > > No need for byteswapping in YV12 decoding on BE machines
> > >
> > > The hardware seems to do the proper thing already, so always use the same
> > > code on both little-endian and big-endian machines.  Fixes xv YV12 on a
> > > TechSource Raptor GFX aka Sun PGX32.
> > >
> > > Signed-off-by: Mark Kettenis <kettenis at openbsd.org>
> > 
> > Nice! Good catch.
> > 
> > I suppose this fixes the problem you discovered in the other thread?
> > 
> > I'll commit this.
> 
> Might want to check the hardware manuals on this, but there might be a
> byteswap bit someplace that does it in hardware. The PGX32 may do this
> at BIOS init time, whereas a PC version may not. There is a bit for this
> on the PM3, so there maybe something on PM2.
> 
> Just thinking if you drop a PC card into a BE machine will it still
> work ?

Oh, if I remember correctly this code was added when Amiga VisionPPC
board support was added. So it must have been relevant at some point for
BE machines.

Alan.



More information about the xorg-devel mailing list