[PATCH 1/5] xfree86: Symmetrize xf86AccessEnter and xf86AccessLeave

Tiago Vignatti tiago.vignatti at nokia.com
Fri Dec 17 04:50:14 PST 2010


On Thu, Dec 16, 2010 at 03:31:36PM -0500, ext Adam Jackson wrote:
> Enter was changing server operating state, Leave wasn't.  Which was
> wholly redundant, since all callers of Enter would immediately change
> the operating state to exactly what Enter had just done.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  hw/xfree86/common/xf86Bus.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86Bus.c b/hw/xfree86/common/xf86Bus.c
> index 90c1914..623b130 100644
> --- a/hw/xfree86/common/xf86Bus.c
> +++ b/hw/xfree86/common/xf86Bus.c
> @@ -484,8 +484,6 @@ xf86AccessEnter(void)
>      for (i = 0; i < xf86NumEntities; i++)
>          if (xf86Entities[i]->entityEnter)
>  		xf86Entities[i]->entityEnter(i,xf86Entities[i]->private);
> -
> -    xf86EnterServerState(SETUP);
>  }

Reviewed-by: Tiago Vignatti <tiago.vignatti at nokia.com>

BTW, given you're touching bus related stuff, you may get interested on move
on http://cgit.freedesktop.org/~vignatti/xserver/log/?h=bus-cleanup-take3 :)

Thanks!
             Tiago


More information about the xorg-devel mailing list