Handling GenericEvents in XSendEvent()

[Daniel Stone]

On Mon, Dec 20, 2010 at 02:39:14PM -0500, Peter Harris wrote:
> On 2010-12-20 10:23, Daniel Stone wrote:
> > On Mon, Dec 20, 2010 at 09:58:18AM -0500, Peter Harris wrote:
> >> This needs something like <list type="BYTE" name="data" /> to describe
> >> the rest of the event. (See also: PutImage)
> > 
> > Rather.  Ahem.  Can you tell I've never used XCB before?
> 
> We all have to start somewhere. Thanks for making the effort.

No problem.

> > I've amended
> > and pushed a new version;
> 
> You don't define "length" anywhere. This causes libxcb to error out when
> it tries to compile xcb-ge.
> 
> The "length" field is implicit in replies, but not in requests. The
> canonical way to handle lists (in requests) that consume the remaining
> length is to leave out the explicit length entirely.
> ie: <list type="foo" name="bar" />

Aha, that'll learn me for trying to be so clever.  Fixed and repushed.

> > for bonus points, it even installs ge.xml.
> > Should libxcb also be generating xcb-ge, or?
> 
> Yes, libxcb should be generating xcb-ge. I don't use libxcb much (just
> xcb/proto directly), so I hadn't noticed that it was missing. Good catch.

OK, I've pushed a trivial implementation into my libxcb repository -
could you please take a look?

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101220/960250ff/attachment.pgp>