[PATCH modular 14/14] build.sh: verify PREFIX is a directory and is writable

Ville Syrjälä syrjala at sci.fi
Wed Dec 29 08:39:27 PST 2010


On Wed, Dec 29, 2010 at 11:30:03AM -0500, Gaetan Nadon wrote:
> This will catch the case where user forgets to set PREFIX
> and does not have write permission in the /usr/local default location
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  build.sh |   23 ++++++++++++++++++++++-
>  1 files changed, 22 insertions(+), 1 deletions(-)
> 
> diff --git a/build.sh b/build.sh
> index 1a29758..afcb158 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -68,6 +68,10 @@ setup_buildenv() {
>      check_full_path $LIBDIR LIBDIR
>      check_full_path $LOCALSTATEDIR LOCALSTATEDIR
>  
> +    # This will catch the case where user forgets to set PREFIX
> +    # and does not have write permission in the /usr/local default location
> +    check_writable_dir $PREFIX PREFIX

Seems like it should check ${DESTDIR}${PREFIX} instead.

-- 
Ville Syrjälä
syrjala at sci.fi
http://www.sci.fi/~syrjala/


More information about the xorg-devel mailing list