[PATCH 9/9] DIX: Reset window properties when freeing them

Fernando Carrijo fcarrijo.lists at gmail.com
Thu Dec 30 21:41:55 PST 2010


Daniel Stone <daniel at fooishbar.org> wrote:

> This enables us to reliably inspect properties when destroying windows.
> 
> Signed-off-by: Daniel Stone <daniel at fooishbar.org>
> ---
>  dix/property.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/dix/property.c b/dix/property.c
> index 1d4332a..a1ae530 100644
> --- a/dix/property.c
> +++ b/dix/property.c
> @@ -424,6 +424,9 @@ DeleteAllWindowProperties(WindowPtr pWin)
>  	dixFreeObjectWithPrivates(pProp, PRIVATE_PROPERTY);
>  	pProp = pNextProp;
>      }
> +
> +    if (pWin->optional)
> +        pWin->optional->userProps = NULL;
>  }
>  
>  static int
> -- 
> 1.7.2.3

Yeah, restoring the default state of the field is a good idea.

Reviewed-by: Fernando Carrijo <fcarrijo at freedesktop.org>


More information about the xorg-devel mailing list