[PATCH libX11 3/4] man: Fix value of XkbAllComponentsMask in XkbGetKeyboard

Jeremy Huddleston jeremyhu at apple.com
Wed Feb 3 10:51:36 PST 2010

On Feb 3, 2010, at 10:12, Dirk Wallenstein wrote:

> On Tue, 02 Feb 2010 13:44:48 -0800 Jeremy Huddleston wrote:
>> I'd prefer to see this written as:
>> (1L<<7) - 1L
> If it's a value I'd like to have it in sync with the code for easy
> comparison. I can change both if you like. Alternatively I could use  
> the
> OR-ed other masks.

I think (next - 1) is less prone to human error when adding bits in  
the future.  That's my main concern.

I think OR-ing all the others does not scale well and also suffers  
from the same human-error aspect.

Consistency is great.  Add the change to the header as well, I think  
that's a good idea.

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5820 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20100203/8a4e587b/attachment.bin 

More information about the xorg-devel mailing list