[PATCH kbproto 2/5] Convert mask specifications to (next - 1) scheme
halsmit at t-online.de
Sat Feb 6 10:19:37 PST 2010
On Sat, 6 Feb 2010 14:20:39 +0100 (CET) Mark Kettenis wrote:
> > From: Dirk Wallenstein <halsmit at t-online.de>
> > Date: Fri, 5 Feb 2010 20:42:44 +0100
> > This makes editing flags less error-prone.
> But this doesn't work if the mask doesn't start with bit 0.
Many do. Less possible errors there.
It also promises to users: "All above are in". Without further need for
> Oh, and it changes the type of the constants too.
They take the type of the components. I think that's an improvement.
> I don't think this is a good idea.
More information about the xorg-devel