[PATCH] Xi: assume BadMode for non-BadMatch errors returned from SetDeviceMode.

Dan Nicholson dbn.lists at gmail.com
Thu Feb 18 08:22:17 PST 2010

On Wed, Feb 17, 2010 at 9:49 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> The XI protocol spec only allows for two errors on the SetDeviceMode
> requests: BadMatch or BadMode. BadMode however is a dynamically assigned
> extension error and the driver doesn't have access to the actual error
> number. Hence, if a SetDeviceMode driver returns an error other than
> BadMatch, assume BadMode.
> The two exceptions are BadAlloc and BadImplementations, pass these on to the
> client (any request is allowed to return either of those).
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Seems reasonable.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

More information about the xorg-devel mailing list