[PATCH] dix: try to ring the bell even if the current device doesn't have one. (#24503)

Adam Jackson ajax at nwnk.net
Mon Feb 22 10:26:31 PST 2010

On Fri, 2010-02-19 at 08:09 +1000, Peter Hutterer wrote:
> Evdev devices do not have the bell proc set, but XTEST devices do. By
> exiting early, the bell only rings if the last keyboard used was the XTEST
> keyboard and hence the bell proc is still set on the master but not if an
> evdev keyboard was used last.
> The better approach here is to try to ring the bell on all devices attached
> to this master device in case one or more actually do produce an audible
> sound. That's also XKB's behaviour if XkbUseCoreKbd is specified as device
> identifier.
> X.Org Bug 24503 <http://bugs.freedesktop.org/show_bug.cgi?id=24503>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> Tested-by: Rafał Mużyło <galtgendo at o2.pl>

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100222/fe669a0f/attachment.pgp>

More information about the xorg-devel mailing list