[PATCH] evdev: pass the valuators to the X server for ButtonPress/Release events.

Julien Cristau jcristau at debian.org
Thu Feb 25 02:45:59 PST 2010


On Thu, Feb 25, 2010 at 12:35:00 +0200, Oliver McFadden wrote:

> On Thu, 2010-02-25 at 11:25 +0100, ext Julien Cristau wrote:
> > On Thu, Feb 25, 2010 at 10:21:07 +0200, Oliver McFadden wrote:
> > 
> > > Previously this was not implemented because it requires the X server has
> > > the xf86PostButtonEventP() function which was not released at the time.
> > > 
> > Can you either keep the code working with older X servers with an ifdef,
> > or update configure.ac to require a new enough xorg-server.pc?
> 
> Yeah, this is probably a good idea. I'll dig through the X server log
> later today and check which version is required.
> 
> Also, which is preferred; an #if check on XORG_VERSION_CURRENT or a
> configure.ac check?
> 
I'd say either use xorg-server >= $version in configure.ac's
PKG_CHECK_MODULES call (if you want to require a new server), or add an
AC_CHECK_DECL(xf86PostButtonEventP) and a #ifdef (if you want to keep
the driver working with older server).

Cheers,
Julien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100225/d6f5c6aa/attachment.pgp>


More information about the xorg-devel mailing list