[PATCH] INSTALL doesn't belong in docdir

Gaetan Nadon memsize at videotron.ca
Sat Jan 2 12:56:48 PST 2010

On Sat, 2010-01-02 at 14:28 -0500, Gaetan Nadon wrote:

> On Sat, 2010-01-02 at 11:12 +0000, Julien Cristau wrote: 
> > On Sat, Jan  2, 2010 at 11:06:05 +0000, Julien Cristau wrote:
> > 
> > > -macros_docdir=`$PKG_CONFIG --print-errors --variable=docdir xorg-macros`
> > > -INSTALL_CMD="(cp -f "$macros_docdir/INSTALL" \$(top_srcdir)/.INSTALL.tmp && \
> > > +macros_datadir=`$PKG_CONFIG --print-errors --variable=pkgdata xorg-macros`
> > 
> > bah.  make that --variable=pkgdatadir.
> Ok. I had not read this e-mail yet.
> I was informed a while back that bumping the module version has to be
> done in a separate patch for administrative reasons. 

I did some test scenario regarding backward compatibility. It turns out
setting docdir=pkgdatadir does not help. The value of docdir in the
module's copy of INSTALL_CMD is set at configuration time. If the module
was configured with macros @ v1.4, then the INSTALL_CMD will copy from
share/doc every time the makefile target is invoked.

-f /home/nadon/xorg/src/share/doc/util-macros/INSTALL ...

When the file is missing, a zero-byte file is created and the target has
a successful completion code. This is the behaviour by design for both
INSTALL and ChangeLog. When creating tarballs on x.org site, the system
is in a consistent state, so these are always created. 

I would leave the value of docdir as it is, given that it is correct. It
will simply be unused.

> > 
> > Cheers,
> > Julien
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100102/6c84efbb/attachment.html 

More information about the xorg-devel mailing list