upstreaming debian's xdm patches

[Julien Cristau]

On Tue, Jan  5, 2010 at 22:00:21 +0100, Matthieu Herrb wrote:

> On Tue, Jan 05, 2010 at 06:18:14PM +0000, Julien Cristau wrote:
> > Matthieu, the old patch had this in the header:
> > 
> > Submitted upstream to Matthieu Herrb on 2003-09-24.
> >   + except for latest changes to genauth.c and session.c, which were
> >     submitted to Matthieu Herrb on 2003-10-14
> > 
> > Do you remember what happened with this, and did you maintain an xdm
> > tree somewhere?
> 
> Only vaguely. This was in the last months of XFree86, so if I committed 
> those patches somewhere it should be in the XFree86 4.4 beta. 
> But I may have slacked on those partches and not have committed before
> XFree86 collapsed. 

OK.  I wasn't seeing these changes in xfree86 cvs so wondered where it
was all coming from :)

> > For some of the patches I'm not sure of the attribution.  The old patch
> > listed Branden Robinson, Matthieu Herrb, and Richard Braakman as
> > authors.
> 
> I could try to dig old mailboxes, but without any guaranty that I still
> have those messages (they are archived on CDs somewhere in my office 
> at work).
> 
> Otherwise:
> 
> Reviewed-by: Matthieu Herrb <matthieu.herrb at laas.fr>
> 
Thanks! (and to Alan)

> Just one remark for patch 4 (appending to the log file instead of
> truncating it): this will probably require to do something to rotate
> the log file with other logs... but can xdm re-open it after rotation?
> 
Patch 9 adds a signal handler to tell xdm to reopen the log.  This seems
to have worked for us.  Only problem with xdm log rotation (afaik) is
that any running X server will still have its stderr pointing to the old
log, which means that when the log is compressed after rotation, X
stderr points to a deleted file.  I'm not sure how to fix that.

Cheers,
Julien