[PATCH] Re-enable the RECORD extension. (#20500)

Keith Packard keithp at keithp.com
Thu Jan 7 23:38:23 PST 2010

On Fri, 8 Jan 2010 15:27:27 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> Eventually the callbacks should be updated to work with InternalEvents (only
> RECORD actually uses the callbacks). Currently, WriteEventsToClient deals
> with wire events and changing it to keep the InternalEvent constitutes an
> ABI break.

I'm not quite sure I see the connection between using xEvents for the
callback and having WriteEventsToClient handle InternalEvents; it seems
like the callback should take InternalEvents and do what it likes with
those, including converting them to xEvents if necessary. In particular,
it looks to me like merging this patch will cause a whole bunch of
unnecessary work when RECORD is initialized, even if no-one is listening
for RECORD events, no?

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20100107/de515841/attachment.pgp 

More information about the xorg-devel mailing list