[PATCH synaptics 2/2] configure: don't clobber CFLAGS

Gaetan Nadon memsize at videotron.ca
Fri Jan 8 10:25:00 PST 2010

On Fri, 2010-01-08 at 08:37 -0800, Dan Nicholson wrote:

> On Fri, Jan 8, 2010 at 8:32 AM, Julien Cristau <jcristau at debian.org> wrote:
> > On Fri, Jan  8, 2010 at 08:26:14 -0800, Dan Nicholson wrote:
> >
> >> This seems to have dropped the -I$(top_srcdir)/src that was being
> >> mangled in in configure. Is that still needed?
> >>
> > It seemed to build fine without it, so I left it out.

Just a reminder to run 'make distcheck' for that type of changes. It
exercises the paths in a different way as the build dir isn't the same
as the source dir. In some cases, the order of includes is important
when a header file is in multiple locations. Thanks for fixing this.

> Yeah, none of the headers in there seem like they're needed outside of
> that directory. None of them get installed, either, so you wouldn't be
> picking up your system copy if you were missing the -I.
> Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>
> --
> Dan
> _______________________________________________
> xorg-devel mailing list
> xorg-devel at lists.x.org
> http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.x.org/archives/xorg-devel/attachments/20100108/6087a89b/attachment.html 

More information about the xorg-devel mailing list