[PATCH 08/11] xfree86: replace True/False with TRUE/FALSE.
peter.hutterer at who-t.net
Fri Jan 15 14:40:28 PST 2010
On Fri, Jan 15, 2010 at 08:35:19AM -0800, Dan Nicholson wrote:
> On Thu, Jan 14, 2010 at 9:32 PM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > xf86Xinput.c relied on xkbsrv.h's definition of True/False which seems odd
> > at first and weird on second glance.
> Hey, I put those in! I personally like True/False or true/false better
> than all caps, but am not religious about it.
yeah, and they passed my review too :)
the reason this needs to go is that xkbsrv redefined true/false and after
removing that this was the only place where it broke due to the above
dependency. True/False may be better to read (I don't care much which one
but would rather have one consistently) but this header dependency here was
> Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>
More information about the xorg-devel